allow gamemode mods to use banners as mode images and patches as icons #836
+751
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i hate github i hate github i hate github
some lines were incorrectly tabbed
Co-authored-by: uniboi <[email protected]>
Co-authored-by: uniboi <[email protected]>
Co-authored-by: uniboi <[email protected]>
Only change from default should be
```
NextModeIconPatch
{
ControlName RuiPanel
wide 72
tall 72
visible 0
scaleImage 1
image ""
rui "ui/basic_image_add.rpak"
pin_to_sibling NextGameModeName
pin_corner_to_sibling BOTTOM_RIGHT
pin_to_sibling_corner TOP_RIGHT
}
```
JMM889901
changed the title
|
Seems to work but i would test, some funky stuff happened trying to this is work locally with it just not updating some files and causing random stuff to crash |
|
This is an old PR fixed up, Unfortunately, i did not include the original unmodified mode-select menu file in a separate commit :boowomp: |
GeckoEidechse
added
needs testing
GeckoEidechse
added
the
commits vanilla file
github-actions
bot
added
the
merge conflicts
|
@JMM889901 merge conflicts atm |
|
@JMM889901 if you resolve merge conflicts I can add the necessary vanilla files to get this PR merged o7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies menu_mode_select to add GetPlaylistBannerImage and RegisterPlaylistBannerImage, also modifies ModeButton_GetFocus to show/hide correct rui since basic_menu_image.rpak cannot show banner images, also adds mode_select.menu, only difference here is
NextModeImageCallsignwhich is just an identical panel using the"ui/callsign_icon_button.rpak"rui instead of basic menu imageImageTest.zip
test mod