Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent suicides registering progression stats #813

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Jul 6, 2024

Small fix to prevent stats registering suicides as legit kills when they shouldn't because vanilla doesn't do it.

I.E: If you kill yourself with a grenade, that suicide will count towards the require amount of pilot kills to unlock camos.

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change. Was already discussed in vc and the effect of it. No further review/testing needed.

@GeckoEidechse GeckoEidechse changed the title [Progression] Prevent suicides registering stats Prevent suicides registering progression stats Jul 6, 2024
@GeckoEidechse GeckoEidechse merged commit e898b0a into R2Northstar:main Jul 6, 2024
4 checks passed
@GeckoEidechse GeckoEidechse added the progression Changes related to progression system label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progression Changes related to progression system
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants