Rework Intro Dropship Script to avoid player overlap #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will re-add them afterwards pinky promise
again, I will add them back, pinky promise
GeckoEidechse
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
@Zanieon already extensively tested this in his FD branch so testing can be skipped.
Additionally we went over the PR together and I feel I understand it well enough to confidently merge it ^^
This was referenced Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rework had me gone through several approaches to fix the inconsistent behavior we have in regards to the Intro Dropships which is whenever there's more than 4 players in a Dropship the second one is still unlikely to be used. Code was instead just overlaping the extra players on top of the players of the first Dropship.
This overhaul makes the Dropships behave consistently now like vanilla and players will only start overlapping each other when both Dropships are full, otherwise code will always attempt to populate them properly instead.