Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfuck the Spawns #808

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Jul 5, 2024

Here's my babble to finally get rid of the shitty spawns for basically all gamemodes and especially make CTF playable.

What this PR tries to do:

  1. Get rid of the odd logic of limiting the algorithm to 3 spawn points only, resulting in a very predictable and frustrating behavior.
  2. Changes the specific CTF algorithm to calculate the spawn points from the Flag bases themselves rather than the initial spawn points which was causing severe inconsistencies.
  3. Remove some checks in regards to Map Side Swapping when matches reaches Half-Times, because apparently native code does flip the owning team of the spawn points together when that happens.
  4. Mitigate usage of GetOtherTeam for certain checks since that function might return Unreachable when it's a gamemode with more than 2 Teams and intentionally script crash the server.

@Zanieon Zanieon added needs testing Changes from the PR still need to be tested feedback wanted Feedback is wanted whether the changes by this PR are desired labels Jul 5, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing in CTF when testing with 2 players.

After halftime the players still spawned on the correct side (i.e. switched now together with their flag base).
Players carrying the flag also don't affect the spawns (they used to have a big effect at some point but not sure if that was with a merged change or just during a playtest of an older PR).

@GeckoEidechse GeckoEidechse removed the needs testing Changes from the PR still need to be tested label Jul 5, 2024
@GeckoEidechse GeckoEidechse merged commit 0198d3f into R2Northstar:main Jul 5, 2024
3 checks passed
@Zanieon Zanieon deleted the unfugged_spawns branch July 5, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Feedback is wanted whether the changes by this PR are desired
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants