Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doubletake iron sight zoom from SP #674

Closed
wants to merge 12 commits into from

Conversation

EnderBoy9217
Copy link
Contributor

@EnderBoy9217 EnderBoy9217 commented Jul 28, 2023

Adds a "iron_zoom" weapon mod that modders can use that re-implements the weapon zoom from singleplayer.
This does not affect normal doubletake (without a custom server-side mod)
This does not require a version gate, servers without the update simply wont have the feature, clients without the update will simply see a normal iron sight.

(Ignore the previous 10 commits those were for another PR and their changes have been removed from this one)

Video example of what the weapon mod does when applied:
https://github.com/R2Northstar/NorthstarMods/assets/122132914/6dccd37d-f31e-4708-99f9-f23434fed3d8

@GeckoEidechse GeckoEidechse added the feedback wanted Feedback is wanted whether the changes by this PR are desired label Jul 28, 2023
@GeckoEidechse
Copy link
Member

Someone please give feedback whether we want to add this or no

@ASpoonPlaysGames
Copy link
Contributor

Someone please give feedback whether we want to add this or no

I'm of the opinion that this should be an external mod personally

@uniboi
Copy link
Contributor

uniboi commented Jul 28, 2023

This should be a mod tbh

@EnderBoy9217
Copy link
Contributor Author

Remember this is just used as a tool for modders, without installing a separate server-side mod this doesn't affect anything.

@EM4Volts
Copy link
Contributor

EM4Volts commented Jul 29, 2023

same opinion as others, this feels more like a seperate mod.
besides that making another version gate simply so people can zoom in a bit with the doubletake seems like a overdone thing

@GeckoEidechse
Copy link
Member

This does not require a version gate, servers without the update simply wont have the feature, clients without the update will simply see a normal iron sight.

So just to be clear, this change would need to be on client and server to work, right?

@EM4Volts
Copy link
Contributor

This does not require a version gate, servers without the update simply wont have the feature, clients without the update will simply see a normal iron sight.

So just to be clear, this change would need to be on client and server to work, right?

yes since it modifies the script file of the weapon directly, sames as DoubleBarrel did with the script file.

@GeckoEidechse
Copy link
Member

Aight, in that case it might be the perfect example for auto-mod-download (#542, R2Northstar/NorthstarLauncher#362) given especially its small self-contained change.

@EnderBoy9217 maybe upload this to Thunderstore and talk to @Alystrasz to use it as a sample mod for auto-mod-downloading ^^

@ASpoonPlaysGames
Copy link
Contributor

Technically speaking not all weapon script file changes are needed on client, just the ones that the client reads.

@GeckoEidechse
Copy link
Member

With that said, I'm gonna close this PR as so far the response was to have it as a mod. I know server-client mods are basically dead atm due to missing auto-mod-download. Hopefully we can change that soon ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Feedback is wanted whether the changes by this PR are desired
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants