Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing strings for Double Barrel and Arc Cannon #671

Merged
merged 9 commits into from
Aug 1, 2023
Merged

Add missing strings for Double Barrel and Arc Cannon #671

merged 9 commits into from
Aug 1, 2023

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Jul 25, 2023 •
edited by GeckoEidechse
Loading

Adds the missing strings for:

  1. Double Barrel Shotgun
  2. Arc Cannon
  3. Frontier Defense Wave Names for Maps that currently don't have them.

Includes Translations in Portuguese since i am a native speaker of it.

@Zanieon Zanieon changed the title Add missing strings entries Add missing strings for Double Barrel, Arc Cannon and FD Wave Names Jul 25, 2023
EM4Volts
EM4Volts reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@EM4Volts EM4Volts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

english looks fine, as for portuguese i dont know, i dont speak portuguese.

F1F7Y
F1F7Y approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in testing, english translations look good

@ASpoonPlaysGames ASpoonPlaysGames added the almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge label Jul 30, 2023
@GeckoEidechse GeckoEidechse changed the title Add missing strings for Double Barrel, Arc Cannon and FD Wave Names Add missing strings for Double Barrel and Arc Cannon Aug 1, 2023
GeckoEidechse
GeckoEidechse reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took out the FD name changes to put them into separate PR.

@GeckoEidechse GeckoEidechse merged commit 2b26328 into R2Northstar:main Aug 1, 2023
3 checks passed
@GeckoEidechse GeckoEidechse mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EM4Volts EM4Volts EM4Volts left review comments

@GeckoEidechse GeckoEidechse GeckoEidechse left review comments

@F1F7Y F1F7Y F1F7Y approved these changes

Assignees
No one assigned
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zanieon @GeckoEidechse @F1F7Y @EM4Volts @ASpoonPlaysGames