-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix INVALID_REF errors caused by mods #657
Fix INVALID_REF errors caused by mods #657
Conversation
tf... ill look into that tomorrow then |
That looks normal? I probably should've mentioned that the actual gun skin looks like default, it's the icon thing you should be looking at |
Flightcore overwrote the folder so i cant check, Ill test it again tho |
I would normally just add a check to prevent this crash, but this code needs to run, or you'll just get a crash later on. I might throw an error that's a bit more descriptive though |
Having the masterwork skin selected and going into the "Pilot loadouts" menu with MoreSkins disabled causes this |
Still can't replicate on my end unfortunately EDIT: ok I can replicate now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't manage to break it, changes look good
NOTE: Adds vanilla files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ASpoonPlaysGames from which VPK are the files from? ^^
englishclient_frontend |
@GeckoEidechse bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please please please the code is good and does what it's supposed to
Merging based on past reviews. |
`INVALID_REF` errors were being caused by trying to get the item image for weapon skins. If a mod (e.g. moreskins) added new skins, the client equipped one, and then the mod is disabled, the client now has bad persistence. This is mostly handled fine by the game, except for weapon skins. This PR prevents the crash, and resets the bad persistence to default.
INVALID_REF errors were being caused by trying to get the item image for weapon skins.
If a mod (moreskins) added new skins, the client equipped one, and then the mod is disabled, the client now has bad persistence.
This is mostly handled fine by the game, except for weapon skins. This PR prevents the crash, and resets the bad persistence to default.
Testing:
Note: This PR introduces two vanilla files,
menu_pilot_loadouts_shared.nut
andmenu_edit_pilot_loadouts.nut
toNorthstar.Client/mod/scripts/vscripts/ui
, they will need to be committed as Respawn.