Fix Infinite Loading Screen + Fix Modsettings "int" functionality

[EnderBoy9217]

Previously if a server crashed while the client was in the map loading screen, all clients would be stuck in an infinite loading screen. (This was reproduced by multiple people)

This boots clients back to the menu if the game hasn't loaded within 30 seconds (server crash) and loads the main menu, it doesn't affect the campaign's "continue" feature either.

Video below (some footage sped up by 8x to reduce video size)

Loading.Screen.Fix.mp4

EDIT:
This adds a Northstar.Client section to modsettings
This also fixes an issue where modsettings cannot take an "int" ConVar
Closes: R2Northstar/Northstar#489

[uniboi]

Maybe open a dialog when returning to the main menu that tells the user that the loading has timed out

[EnderBoy9217]

Added an error message for when this happens

[F1F7Y]

My main concern would be what if the loading actually takes more than 30 seconds?

Please also comment your code, scripts are already chaotic the way they are right now

[uniboi]

I think 30 seconds before a timeout is fine

[EnderBoy9217]

Added the comments and uni's suggestions, also added a loop to reduce the chance of a false positive from loading multiple times
Unless anyone knows a way to cancel the thread with another function instantly

[uniboi]

is there a point in aborting the function early? I'd just keep the wait threshold because letting the function run is cheaper than checking every second if the client is still loading.
Maybe there's a signal we can use, that'd be more elegant

[ASpoonPlaysGames]

Maybe there's a signal we can use, that'd be more elegant

there are various signals that might be of use (all of which are called on uiGlobal.signalDummy)

LevelShutdown
LevelFinishedLoading

i think LevelShutdown is best for this tbh

[uniboi]

LevelShutdown triggers right before the map unloads iirc.
I'd make the function something like this

void function TimeoutHandler()
{
	const int timeoutThreshold = 30 // how long this function will wait before disconnecting
	EndSignal( uiGlobal.signalDummy, "LevelFinishedLoading" ) // cancel the thread if the level has finished loading

	wait timeoutThreshold;

	if ( uiGlobal.isLoading == true ) // Disconnect if the client still hasn't connected
	{
		printt( "TimeoutHandler disconnected because loading took too long" )
		UICodeCallback_LevelLoadingFinished( true ) // Removes loading screen
		Disconnect() // Loads main menu
		OpenErrorDialog( format( "Loading timed out (Over %i seconds)", timeoutThreshold ) ) // Opens error dialog to notify user
	}
}

[EnderBoy9217]

couldnt we get rid of the "if" statement if that signal ends the script
As that signal is sent right after isLoading becomes false

Edit: (nevermind 1 other script can change the bool)

[EnderBoy9217]

endsignal causes the script to not work @uniboi , it will print that it is attempting to send the player back to lobby "TimeoutHandler disconnected because loading took too long" but it won't

Is there any other known way to end the script, or should we go back to the for loop

[uniboi]

Try changing the function to this:

void function TimeoutHandler()
{
	const int timeoutThreshold = 30 // how long this function will wait before disconnecting
	EndSignal( uiGlobal.signalDummy, "LevelFinishedLoading" ) // cancel the thread if the level has finished loading

	OnThreadEnd(
		void function()
		{
			if ( uiGlobal.isLoading == true ) // Disconnect if the client still hasn't connected
			{
				printt( "TimeoutHandler disconnected because loading took too long" )
				UICodeCallback_LevelLoadingFinished( true ) // Removes loading screen
				Disconnect() // Loads main menu
				OpenErrorDialog( format( "Loading timed out (Over %i seconds)", timeoutThreshold ) ) // Opens error dialog to notify user
			}
		}
	)

	wait timeoutThreshold;
}

[EnderBoy9217]

I have no idea what you did there @uniboi
But it didn't load the main menu ui, only the dialog and .bik file

[EnderBoy9217]

The current code still works but likely isn't the most optimal, if anyone has an alternative that doesn't use EndSignal (which seems to be causing issues) let me know

[uniboi]

I'll take a look tomorrow

[GeckoEidechse]

Added the comments and uni's suggestions, also added a loop to reduce the chance of a false positive from loading multiple times.

Make sure to click the Resolve button on the conversations where it's applicable so we know that part has been addressed ^^

[F1F7Y]

I'll take a look tomorrow

@uniboi bump

[EnderBoy9217]

Added ConVar and per Spoon's request added it to modsettings

This also adds a Northstar.Client section to modsettings

This PR now fixes an issue where modsettings cannot take an "int" ConVar

Put both of these in PR description as well

[EnderBoy9217]

Changed it from an int to a float

[ASpoonPlaysGames]

Just a few more things from me

[ASpoonPlaysGames]

Code looks good :)

[EnderBoy9217]

I got an odd error while playing with this and I think its related

nslog2023-08-27 12-09-30.txt

[ASpoonPlaysGames]

indeed it is

[EnderBoy9217]

I believe its fixed with an "IsConnected()" check I just added, works fine in testing

[EnderBoy9217]

Also this fix works if the masterserver was to go down while someone was loading for some reason

[F1F7Y]

Blocking as:

1. Each fix should be a separate PR
2. The "fix" for infinite loading screen is really hacky and should be handled in native by checking the connection like valve source does.