-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only fetch MAD manifesto on server join #751
Only fetch MAD manifesto on server join #751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed it all, don't see anything needing changing, not tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand the code changes they seem correct to me ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working in testing together with R2Northstar/NorthstarMods#821
Enabled MAD and joined a server. Observed the delayed manifesto fetching as intended.
Previously, the verified mods manifesto was fetched on game start without checking if the verified mod feature is enabled Squirrel-side; with this, the manifesto is only fetched when the user wants to download a mod (meaning they enabled the feature beforehand).
Previously, the verified mods manifesto was fetched on game start without checking if the verified mod feature is enabled Squirrel
-side; with this, the manifesto is only fetched when the user wants to download a mod (meaning they enabled the feature beforehand).
(must be merged with the mods PR!)
Launcher changes
FetchModsListFromAPI
method to Squirrel VMFetchModsListFromAPI
method on client startModInstallState.MANIFESTO_FETCHING
enum value to better track mod install progressTODOs
Testing
Without PRs:
With PRs:
allow_mod_auto_download 1
);Space battle
orParkour
server should be up at the time of writing);Media
delayed_manifesto_fetching.webm
(if you look closely, you can see verified mods manifesto is fetched WHEN joining the server, around
0:12
in the video)