Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix const-qualified assignment in RapidJSON #717

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Fix const-qualified assignment in RapidJSON #717

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a59c39
fix const-qualified assignment in RapidJSON
Jan200101 Jun 16, 2024
681d01f
Merge branch 'main' into PR/rapidjson-const
GeckoEidechse Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions primedev/thirdparty/rapidjson/document.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,6 @@ struct GenericStringRef {

GenericStringRef(const GenericStringRef& rhs) : s(rhs.s), length(rhs.length) {}

GenericStringRef& operator=(const GenericStringRef& rhs) { s = rhs.s; length = rhs.length; }

//! implicit conversion to plain CharType pointer
operator const Ch *() const { return s; }

Expand All @@ -330,6 +328,8 @@ struct GenericStringRef {
//! Disallow construction from non-const array
template<SizeType N>
GenericStringRef(CharType (&str)[N]) /* = delete */;
//! Copy assignment operator not permitted - immutable type
GenericStringRef& operator=(const GenericStringRef& rhs) /* = delete */;
};

//! Mark a character pointer as constant string
Expand Down