Skip to content

fix: improve deepUpdate logic for array item matching #7507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Apr 11, 2025

What is it?

https://qwikdev-build-v2.qwik-8nx.pages.dev/playground/#f=7VbLCsJADPyVpaeFPtCDiGA96EnQg%2FYXLFgonvRU%2Bu9Okq3N6rYo4s1LoW2SzYTZySjSzGcPOJo0icdgfpNdnJg3bIrAL7B9atIqUrLtBUrRFTwcd5hLkGySeoVsI8K7RRIzAYKekl7VNVsUzs0beraYhJDUbyyUpdtZYkeurGWr89QYSVrBWxA82tBaguBwozIeK%2F0FghGlcZpgqQz6civjmGoY8VoZIZHv9JXRdAecsa%2Fqko3IeHnLXVGueaGhODtTnfKoosGkNAiaTCp%2Fot7rNOrAtiOZHL8vTTOMqHUUdC7SEZHb%2Bc7ZjnPMXQTtcIcla7pQpvwTyfJuwV%2BwfiFYdw

there are six bundles, but only three bundles appears in the list

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner April 11, 2025 06:32
Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: 69dd8fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JerryWu1234
Copy link
Contributor Author

@wmertens @Varixo does this need to add a changeset ?

Copy link
Contributor

github-actions bot commented Apr 11, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 69dd8fb

@JerryWu1234 JerryWu1234 self-assigned this Apr 11, 2025
@JerryWu1234 JerryWu1234 moved this from Backlog to Waiting For Review in Qwik Development Apr 11, 2025
@JerryWu1234
Copy link
Contributor Author

image

@JerryWu1234
Copy link
Contributor Author

@Varixo done

@Varixo
Copy link
Member

Varixo commented Apr 22, 2025

Thanks!

@Varixo Varixo merged commit 50141a9 into QwikDev:build/v2 Apr 22, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants