Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: wait for QRL to resolve for signal attribute" #7246

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Revert "fix: wait for QRL to resolve for signal attribute" #7246

merged 1 commit into from
Jan 12, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Jan 12, 2025

Reverts #7243

@Varixo Varixo self-assigned this Jan 12, 2025
@Varixo Varixo requested a review from a team as a code owner January 12, 2025 09:13
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2025

⚠️ No Changeset found

Latest commit: 2f8cec9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

shairez
shairez approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@shairez shairez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Varixo Varixo merged commit cae8268 into build/v2 Jan 12, 2025
14 checks passed
@Varixo Varixo deleted the revert-7243-v2-signal-prop-qrl branch January 12, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shairez shairez shairez approved these changes

Assignees

@Varixo Varixo

Labels
VERSION: upcoming major
Projects
Qwik Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Varixo @shairez