Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(optimizer): ignore unknown deps in graph #6888

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(optimizer): ignore unknown deps in graph #6888

wants to merge 1 commit into from
+30 −17

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Sep 18, 2024 •
edited
Loading

There have been reports of a problem building the graph

EDIT: confirmed working

@wmertens wmertens requested a review from a team as a code owner September 18, 2024 07:25
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: eb845d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 18, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6888

npm i https://pkg.pr.new/@builder.io/qwik-city@6888

npm i https://pkg.pr.new/eslint-plugin-qwik@6888

npm i https://pkg.pr.new/create-qwik@6888

commit: eb845d0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview eb845d0

@wmertens wmertens force-pushed the fix-manifest branch 2 times, most recently from 75a6223 to 50c099a Compare September 18, 2024 16:45
@wmertens wmertens enabled auto-merge (rebase) September 18, 2024 21:55
thejackshelton-kunaico
thejackshelton-kunaico approved these changes Sep 18, 2024 •
edited
Loading
View reviewed changes
thejackshelton
thejackshelton previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@thejackshelton thejackshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's change the weird but ok comment to something like:

// return when bundle is not found in the graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejackshelton-kunaico thejackshelton-kunaico thejackshelton-kunaico approved these changes

@thejackshelton thejackshelton thejackshelton left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wmertens @thejackshelton @thejackshelton-kunaico