Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): add parent filename to qrl segments #6881

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Sep 16, 2024

This allows nicer debugging because you can easily see which segment file belongs to which original file

image

This also uses the full displayname in production qrl segments for nicer debugging (doesn't impact bundling)

+ use full displayname in production qrl segments for nicer debugging (doesn't impact  bundling)
@wmertens wmertens requested a review from a team as a code owner September 16, 2024 07:00
@wmertens wmertens enabled auto-merge (squash) September 16, 2024 07:00
Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 3f87ba4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 16, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6881
npm i https://pkg.pr.new/@builder.io/qwik-city@6881
npm i https://pkg.pr.new/eslint-plugin-qwik@6881
npm i https://pkg.pr.new/create-qwik@6881

commit: f2709d0

Copy link
Contributor

github-actions bot commented Sep 16, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview f2709d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant