Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): support FlatConfig #6628

Conversation

naorpeled
Copy link
Member

@naorpeled naorpeled commented Jul 1, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • [ x ] Docs / tests / types / typos

Description

Use cases and why

Addresses #6048

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Jul 1, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 128fa11

Copy link

pkg-pr-new bot commented Jul 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 128fa11

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6628

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6628

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6628

create-qwik

npm i https://pkg.pr.new/create-qwik@6628


templates

@naorpeled naorpeled force-pushed the feat/packages/eslint-plugin/add-support-for-flat-config branch from 25dcd26 to 128fa11 Compare July 6, 2024 15:05
@wmertens
Copy link
Member

wmertens commented Oct 6, 2024

@naorpeled what's left to do here?

@naorpeled
Copy link
Member Author

@naorpeled what's left to do here?

I don't remember exactly, I will go over this when I get home and let you know asap

@naorpeled naorpeled force-pushed the feat/packages/eslint-plugin/add-support-for-flat-config branch from 128fa11 to e2bdece Compare October 7, 2024 19:22
Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: e2bdece

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@naorpeled
Copy link
Member Author

@wmertens
The declaration files are not generated, I do have a direction on how to do so but if you'd be available to sit over Discord in the next few days it'd be perfect, I want to do things that are aligned with Qwik philosophy as much possible.

Please let me know if that'd be possible 🙏

@naorpeled naorpeled closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants