Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model description #415

Merged
merged 17 commits into from
Sep 2, 2020
Merged

Model description #415

merged 17 commits into from
Sep 2, 2020

Conversation

Allcharles
Copy link
Contributor

@Allcharles Allcharles commented Aug 24, 2020

Model Description Markup

Updated model descriptions, and short descriptions, so that the proper markup is applied.

Changes

  • Update home page to display short description with truncation
  • Updated project list page to display short description with truncation
  • Updated project details page to enable html formatting
  • Updated site details page to enable html formatting
  • Added new dependency: https://github.com/DiZhou92/ngx-line-truncation

Problems

Issues

Closes #379

Visual Changes

Home Page

image

Project List

image

Project Details

image

Site Details

image

@Allcharles Allcharles added enhancement New feature or request ui feature A new feature/page to add to the project work in progress Pull request that is currently a WIP labels Aug 24, 2020
@Allcharles Allcharles marked this pull request as draft August 24, 2020 04:29
Forced all fake models to use a Required version of their interface. This will help track down any changes to the model without associated updates to the generator.
@Allcharles Allcharles requested a review from atruskie August 24, 2020 11:56
@Allcharles Allcharles marked this pull request as ready for review August 24, 2020 11:56
@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2020

Size Change: +4.49 kB (0%)

Total Size: 1.15 MB

Filename Size Change
dist/workbench-client/browser/index.html 1.06 kB -2 B (0%)
dist/workbench-client/browser/main-es2015.********************.js 517 kB +2.2 kB (0%)
dist/workbench-client/browser/main-es5.********************.js 540 kB +2.3 kB (0%)
ℹ️ View Unchanged
Filename Size Change
dist/workbench-client/browser/assets/content/credits.html 907 B 0 B
dist/workbench-client/browser/assets/content/disclaimers.html 1.13 kB 0 B
dist/workbench-client/browser/assets/content/downloadAnnotations.html 191 B 0 B
dist/workbench-client/browser/assets/content/error.html 214 B 0 B
dist/workbench-client/browser/assets/content/ethics.html 2.21 kB 0 B
dist/workbench-client/browser/assets/content/harvest.html 1.21 kB 0 B
dist/workbench-client/browser/assets/content/home.html 866 B 0 B
dist/workbench-client/browser/assets/content/sendAudio.html 2.6 kB 0 B
dist/workbench-client/browser/assets/environment.json 459 B 0 B
dist/workbench-client/browser/manifest.json 150 B 0 B
dist/workbench-client/browser/polyfills-es2015.********************.js 12.6 kB 0 B
dist/workbench-client/browser/polyfills-es5.********************.js 45.1 kB 0 B
dist/workbench-client/browser/runtime-es2015.********************.js 719 B 0 B
dist/workbench-client/browser/runtime-es5.********************.js 719 B 0 B
dist/workbench-client/browser/styles.********************.css 27 kB 0 B

compressed-size-action

@Allcharles Allcharles removed the work in progress Pull request that is currently a WIP label Aug 25, 2020
Copy link
Member

@atruskie atruskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the API will now return properly formatted and truncated taglines for markdown blobs. See QutEcoacoustics/baw-server#488

The *_html_tagline props from QutEcoacoustics/baw-server#488 should obviate the need for the stripHtml function.

@Allcharles
Copy link
Contributor Author

Updated branch to handle QutEcoacoustics/baw-server#488

@Allcharles Allcharles requested a review from atruskie September 1, 2020 04:10
Copy link
Member

@atruskie atruskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only note is that we call those "user ids and dates" stamp. So it might be better to name them userStamps but meh... doesn't need to change

@Allcharles Allcharles merged commit 5b52392 into master Sep 2, 2020
@Allcharles Allcharles deleted the model-description branch September 2, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui feature A new feature/page to add to the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model description markup
2 participants