Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model description html markup #487

Closed
7 tasks done
Allcharles opened this issue Aug 24, 2020 · 1 comment · Fixed by #488
Closed
7 tasks done

Model description html markup #487

Allcharles opened this issue Aug 24, 2020 · 1 comment · Fixed by #488
Labels
architectural bug triage:low
Milestone
Workbench Client

Comments

@Allcharles
Copy link
Collaborator

Allcharles commented Aug 24, 2020 •
edited by atruskie
Loading

There are a few models which have the description and descriptionHtml property. description_html should be a html version of the markdown formatted description parameter. In some models, this relationship is broken and needs to be fixed.

List of potentially affected models to verify:

  • AnalysisJob
  • Bookmark
  • Dataset
  • Project (known working)
  • SavedSearch
  • Script
  • Site (known broken)
@Allcharles Allcharles added this to the Workbench Client milestone Aug 24, 2020
@Allcharles
Copy link
Collaborator Author

Somewhat relates to #486

@Allcharles Allcharles mentioned this issue Aug 24, 2020
Merged
atruskie added a commit that referenced this issue Aug 27, 2020
@atruskie
Standardizes description markdown conversion in API
17f54fd 
Fixes #487

Also adds a bunch of tests. To ensure the description fields are tested and generated we needed to add each class to our new testing framework. This meant adding API tests for every model afected.

Also fixes #406. Fixes #425.
@atruskie atruskie mentioned this issue Aug 27, 2020
Merged
6 tasks
atruskie added a commit that referenced this issue Aug 30, 2020
@atruskie
Standardizes description markdown conversion in API
7ecedaa 
Fixes #487

Also adds a bunch of tests. To ensure the description fields are tested and generated we needed to add each class to our new testing framework. This meant adding API tests for every model afected.

Also fixes #406. Fixes #425.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architectural bug triage:low
Projects
None yet
Milestone
Workbench Client
Development

Successfully merging a pull request may close this issue.

Standardizes description markdown conversion in API QutEcoacoustics/baw-server
1 participant
@Allcharles