Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core question label fixes #2637

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Core question label fixes #2637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fb7c69
Fixed question label alignment
iam-pranav Sep 6, 2024
e330218
Merged with dev
iam-pranav Sep 6, 2024
cb5c440
Modified CSS
iam-pranav Sep 6, 2024
0e41f85
Added class in label element
iam-pranav Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions css/common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,9 @@ footer.qsm-popup__footer button.qsm-popup-secondary-button:hover {
width: auto;
margin-bottom: 10px;
}
.quiz_section .mlw_qmn_new_question .qsm-question-title-label {
display: inline;
}
.quiz_section .mlw_qmn_question.qsm_remove_bold {
font-weight: normal;
display: block;
Expand Down
2 changes: 1 addition & 1 deletion php/question-types/qsm-question-title.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function qsm_question_title_func( $question, $question_type = '', $new_question_
$new_question_title = apply_filters( 'qsm_question_title_before', $new_question_title, $question_type, $question_id );
if ( in_array( intval( get_question_type( $question_id ) ), [ 12, 7, 3, 5 ], true ) ) {
?>
<div class='mlw_qmn_new_question'><label for="question<?php echo esc_attr( $question_id ); ?>"><?php echo esc_html( $new_question_title ); ?> </label></div>
<div class='mlw_qmn_new_question'><label class="qsm-question-title-label" for="question<?php echo esc_attr( $question_id ); ?>"><?php echo esc_html( $new_question_title ); ?> </label></div>
<?php
} else {
?>
Expand Down