Update to 1.20.5 #44
Merged
Update to 1.20.5 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e unused import, replace deprecated use of NbtType
|
Did some basic testing and everything seems to work okay. I have implemented an updater/datafixer for containers locked with key item stacks, which required me to change the way these are stored in a block entity's NBT a bit, this now includes the data version in which the NBT was stored, which allows for easy updating of key items in the future. When no data version is stored, data version 3700 (1.20.4 equivalent) is assumed. Not sure if the way I implemented the datafixer with the data version stored in the block entity's NBT is the best way to do it, but it does work. Old key items from 1.20.4 seem to convert nicely over to the new components system in 1.20.5. |
PotatoPresident
requested changes
Apr 24, 2024
PotatoPresident
approved these changes
May 27, 2024
Foxtrek64
added a commit
to Foxtrek64/HeyThatsMine
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a successful build implementing registry lookups for item serialisation, will test in a moment.