Fixes #26 #39
Draft
Fixes #26 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
What's happening currently: mod is just passing skin value to the crafatar url which is irrelevant (?), as the value itself needs to be decoded. I'm also not sure if crafatar provides the ability to query textures using minecraft texture url, based on crafatar/crafatar#54 still being open. The https://mc-heads.net/ does support it though.
The whole code part could actually be simplified to always use the new part of method (the one in
if), as it would work with regular minecraft skins as well. But that would mean you'd have to abandon crafatar api. I'd like to hear your thoughts on that, therefore I'm marking this as draft :).