Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World Renderer and Friends Mappings #628

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

OroArmor
Copy link
Member

Just a lot of new mappings and refactors

@OroArmor OroArmor added t: new adds new mappings v: snapshot targets a snapshot version of minecraft wip this is a work in progress t: javadoc this pull request updates or adds new javadoc reviews needed please review this PR s: medium PRs with less than 700 lines and more than 200 labels Aug 16, 2024
@ix0rai ix0rai self-requested a review August 16, 2024 23:17
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clound is top 10 typos imo

mappings/net/minecraft/util/ARGB.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/util/ARGB.mapping Outdated Show resolved Hide resolved
@OroArmor OroArmor added s: large PRs with more than 700 lines and removed s: medium PRs with less than 700 lines and more than 200 labels Aug 19, 2024
@OroArmor OroArmor removed the wip this is a work in progress label Aug 19, 2024
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few convention nitpicks

mappings/net/minecraft/client/render/WorldRenderer.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/util/ArgbHelper.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/util/ArgbHelper.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/util/ArgbHelper.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/util/ArgbHelper.mapping Outdated Show resolved Hide resolved
@ix0rai ix0rai added final-comment-period is approved and will soon be merged if no issues are raised and removed reviews needed please review this PR labels Aug 20, 2024
@ix0rai ix0rai merged commit 55301d8 into QuiltMC:24w33a Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
final-comment-period is approved and will soon be merged if no issues are raised s: large PRs with more than 700 lines t: javadoc this pull request updates or adds new javadoc t: new adds new mappings v: snapshot targets a snapshot version of minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants