-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to mapping-io (Glitch's Version) #432
Merged
Merged
Commits on May 20, 2024
-
Port to mapping-io (Glitch's Version)
This is step 0 in adding the ability for Loader to use alternative intermediates for mods, or use something like mojmaps at runtime. This commit migrates the pre-existing MappingConfiguration to use mapping-io, but doesn't do much to actually refactor Loader to take advantage of mapping-io's strengths. This PR moves a few dependencies to be shadowed that Floader moved as well. Tiny Remapper was required to be moved to work with mapping-io, tiny mapping parser was removed by upstream, and I just decided to bring AccessWidener in line with upstream as well. (PS: I know QMT exists-ish, but it's not finished and I want to work on a modloader, not a mappings parser. When and if QMT is finished, we can evaluate migrating to it, but the potential to use a first-party library later shouldn't prevent us from improving Loader today)
Configuration menu - View commit details
-
Copy full SHA for 192f93d - Browse repository at this point
Copy the full SHA 192f93dView commit details -
Fix "duplicate class" spam from Tiny Remapper in RuntimeModRemapper
TR eagerly opens nested ZIP files and flattens them, and this slightly bizarre behavior causes lots of issues when trying to remap mods that include JiJ candidates. To mitigate this, we create a read-only view of *only* the `.class` files. This has minimal memory impact as the FS is copy-on-write, so it is just a big map of file paths.
Configuration menu - View commit details
-
Copy full SHA for ce9c813 - Browse repository at this point
Copy the full SHA ce9c813View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6de720 - Browse repository at this point
Copy the full SHA c6de720View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d80d3b - Browse repository at this point
Copy the full SHA 1d80d3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aeb0f9f - Browse repository at this point
Copy the full SHA aeb0f9fView commit details
Commits on May 23, 2024
-
Proguard is magically adding SequencedCollection to the LVT of MemoryMappingTree.accept in mapping-io. We couldn't find a minimal reproduction, so we're just going to move away from it for now.
Configuration menu - View commit details
-
Copy full SHA for f07dbca - Browse repository at this point
Copy the full SHA f07dbcaView commit details
Commits on May 29, 2024
-
Fix mods that need remapping, but don't contain any class files, caus…
…ing the remapper to crash because the mod directory didn't exist. Also comment out the DedicatedServerOnly annotation on TestMixinGuiHelper, because we're not testing package-stripping annotations any more. This allows us to run the test mod.
Configuration menu - View commit details
-
Copy full SHA for ec90a26 - Browse repository at this point
Copy the full SHA ec90a26View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1b1190 - Browse repository at this point
Copy the full SHA f1b1190View commit details
Commits on Jul 30, 2024
-
Merge branch 'refs/heads/develop' into mappings-fun
# Conflicts: # src/main/java/org/quiltmc/loader/impl/launch/common/MappingConfiguration.java
Configuration menu - View commit details
-
Copy full SHA for 39d7537 - Browse repository at this point
Copy the full SHA 39d7537View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 90782d5 - Browse repository at this point
Copy the full SHA 90782d5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.