Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle additional libraries with QKL #80

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Laxystem
Copy link

@Laxystem Laxystem commented Sep 10, 2023

These libraries are very useful - and bundling them with KQL can save storage space, preventing multiple mods from bundling them each.

@Laxystem Laxystem changed the title Add dependency additional libraries to QKL Bundle additional libraries with QKL Sep 10, 2023
@Pyrofab
Copy link
Member

Pyrofab commented Sep 10, 2023

Turns out adding a separate minecraft serialization library may not be strictly necessary as we already have our own. That said, Fudge's library does provide several types and convenience methods that we do not have yet, as well as the rather large advantage of serializing to PacketByteBuf with maximal efficiency.
Another option would be to add more Codec-related helpers to QKL, and implement optimized codec network serialization in the form of CBOR ops - which would bring better interoperability with other minecraft systems, but also worsen performance of sync operations.

Comment on lines +64 to +66
includeModApi(libs.serialization.minecraft)
includeApi(libs.collections.immutable)
includeApi(libs.klogging)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at how the project is structured, I think those additions would have to go either in the core or in the library subproject.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read the project's README, and it seems like core is for the Kotlin adapter, and library is for FLK and other qkl specific things. So it made sense to us that each "sublibrary" in QKL should be declared in the root project. We could move that tho, not a problem.

@Laxystem
Copy link
Author

As for the weird git diff - this PR also sorts dependency versions alphabetically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants