extra proposal context #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix highlighting - only propose names for the first parameter of each method in test:parameters
ix0rai
added
enhancement
…l-context # Conflicts: # enigma/src/main/java/org/quiltmc/enigma/api/service/NameProposalService.java # enigma/src/test/java/org/quiltmc/enigma/name_proposal/TestFallbackNameProposal.java # enigma/src/test/java/org/quiltmc/enigma/name_proposal/TestNameProposalBypassValidation.java # enigma/src/testFixtures/java/org/quiltmc/enigma/test/plugin/TestEnigmaPlugin.java
Merged
ix0rai
added a commit
that referenced
this pull request
Jan 9, 2025
* add methods and start work on tests * actually use that method oops * implement bypassValidation() * implement fallback for stats * checkstyle tests * store a full `EntryMapping` in `TranslateResult` * add highlighting for fallback mappings * fix crash with trailing commas in profile json * add test proposer for fallback - fix highlighting - only propose names for the first parameter of each method in test:parameters * orange! * good looking colors for fallback * checkstyle * checkstyle * rethrow exceptions in tests * add enigma instance as name proposal context * fix dynamic proposal not accounting for unchecked * fix dynamic proposal putting obf mappings in the wrong tree * checkstyle * forgot javadoc for fallback * add readMappings api methods in Enigma * rework name validation * remove bypassValidation, add dynamic test * improve validation testing * checkstyle * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #240, required for QuiltMC/quilt-mappings#660
Enigmaobject for both proposal methodsEntryRemappernow exposes anEnigmato facilitate thisreadMappingsAPI inEnigmaNameProposalService#bypassValidationwith avalidateProposedMappingmethod that can be overridden to achieve the same effect