Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package renamer improvements #235

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Oct 29, 2024

  • fixes two engima crashes in one issue #211
  • adds a fancy confirmation dialogue before renaming, to make sure that it doesn't produce an unexpected result
    • this is important since it's impossible to undo

image
image

@ix0rai ix0rai added bug Something isn't working user interface affects the enigma ui labels Oct 29, 2024
@ix0rai ix0rai changed the title fix a couple possible crashes in package renamer package renamer improvements Oct 29, 2024
@ix0rai ix0rai changed the base branch from master to develop/2.6 December 6, 2024 23:40
@ix0rai ix0rai merged commit 3a1981d into QuiltMC:develop/2.6 Dec 6, 2024
2 checks passed
@ix0rai ix0rai deleted the fix-package-rename-crashes branch December 6, 2024 23:40
@ix0rai ix0rai mentioned this pull request Jan 6, 2025
ix0rai added a commit that referenced this pull request Jan 9, 2025
* fix a couple possible crashes in package renamer

* checkstyle

* add a confirmation dialogue for package renaming

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user interface affects the enigma ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

two engima crashes in one issue
1 participant