Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default dark theme colors #214

Conversation

supersaiyansubtlety
Copy link
Contributor

Now with darker darks and lighter lights:

Before/after 1

enigma-default-dark-theme-before-after-1

Before/after 2

enigma-default-dark-theme-before-after-2

@supersaiyansubtlety
Copy link
Contributor Author

@ix0rai ix0rai added enhancement New feature or request user interface affects the enigma ui labels Aug 6, 2024
@ix0rai
Copy link
Member

ix0rai commented Aug 8, 2024

i'll be honestly i personally like the old one better
i think the contrast between the code view and the rest of the window is a bit much
would you mind moving this into its own theme?

@supersaiyansubtlety
Copy link
Contributor Author

It would look better if the dark LaF was darker...
(I'd like to make that customizable in another PR, eventually)

I could move it to another theme, but it'd require reworking how default syntaxpane colors are loaded, currently they only allow for one dark and one light set of default colors.

Before I do that I'd like to hear what @OroArmor and @woodiertexas think of this theme.
No need to ship it with Enigma if I'll be the only one using it.

@ix0rai
Copy link
Member

ix0rai commented Aug 9, 2024

i've been meaning to do a proper customisation screen in swing for ages

@OroArmor
Copy link
Member

OroArmor commented Aug 9, 2024

Before I do that I'd like to hear what @OroArmor and @ woodiertexas think of this theme.
No need to ship it with Enigma if I'll be the only one using it.

Hm I agree with rai that I don't really like the darkness of the code compared to the sidebars. If those were darker I think I would like it more

@woodiertexas
Copy link

personally, the enigma UI should be as dark as the code view

@supersaiyansubtlety
Copy link
Contributor Author

Alright, sounds like we all agree it would be better if the non-syntaxpane colors (LaF colors) where also darker.

Closing this in favor of https://github.com/supersaiyansubtlety/enigma/tree/improve-theme-handling.

I aim to implement LaF color customization there.
I'll open a draft PR once the ClassCastException I asked about on discord is sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user interface affects the enigma ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants