Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix name conflict detection #119

Merged
merged 18 commits into from
Jul 10, 2023
Merged

fix name conflict detection #119

merged 18 commits into from
Jul 10, 2023

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Jul 5, 2023 •
edited
Loading

CHANGES:

  • stop using getSiblings to find names, instead relying on the JarIndex. this fixes obfuscated names not being considered for the validity check.
  • fixes shadowing check and updates the test to reflect that
  • remove a couple deprecation annotations and makes the code safer
  • bit of cleanup
  • fix warnings not being properly removed after verification
  • adds a new method to MethodEntry for iterating over parameters

TODO:

  • still doesn't fix parameter checking
  • cleanup
  • fix lang

@ix0rai ix0rai added bug Something isn't working backend affects the enigma backend labels Jul 5, 2023
@ix0rai ix0rai added this to the 1.9.0 milestone Jul 5, 2023
@ix0rai ix0rai marked this pull request as draft July 5, 2023 21:33
@ix0rai ix0rai marked this pull request as ready for review July 6, 2023 23:03
@ix0rai ix0rai requested a review from IotaBread July 6, 2023 23:03
ix0rai and others added 13 commits July 6, 2023 22:17
@ix0rai
fix tests
7996496
@ix0rai
fix shadowing
73b9236
@ix0rai
fix shadowing
eee0076
@ix0rai
fix interface
9dace34
@ix0rai
cleanup
71f8b81
@ix0rai
cleanup 2
0684062
@ix0rai
fix issues
c972802
@ix0rai
fix bugs
c801ef0 
- fix class validation not working
- fix class validation fails still updating class tree
- fix shadowing warning not working when parent is deobf
- fix shadowing warning showing up when methods aren't static
- probably something else idk anymore
@ix0rai
fix bugs 2
ffce80e 
- null pointer
- wrong assertions in test
@IotaBread
Fixes to shadow detection and more tests
f3b950b
@IotaBread
Fix method conflict detection
9a236ff
@IotaBread
Fix checkstyle errors
f3ae81a
@IotaBread
Fix checkstyle errors (again)
db15218
@IotaBread IotaBread merged commit 8bbd6ff into QuiltMC:master Jul 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IotaBread IotaBread IotaBread approved these changes

Assignees
No one assigned
Labels
backend affects the enigma backend bug Something isn't working
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ix0rai @IotaBread