This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
Rename #169
Merged
Rename #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhostofCookie
suggested changes
Aug 22, 2024
| @@ -13,7 +13,7 @@ namespace qtransport { | |||
| template<typename T, class Allocator = std::allocator<T>> | |||
| class StreamBuffer | |||
| { | |||
| using buffer_t = std::deque<T, Allocator>; | |||
| using BufferT = std::deque<T, Allocator>; | |||
There was a problem hiding this comment.
Might have been better to call it BufferType.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames all of
libtransportto match the project's now declared style guide, and enforces naming via clang-tidy.Note that
cmd/is not currently linted, so I will fix that up subsequently.I also added this commit to
.git-blame-ignore-revs, to mitigate at least some of the pain of having a diff on practically every line.I will setup the format harness, and run it, immediately after this PR.
I don't expect anyone to read this entire diff, but you should be able to reproduce it mostly by using the same
clang-tidyfile and runningclang-apply-replacements clang-tidy-fixesfrom the build folder when building with-DLINT=ON, and then correcting the API changes in cmd/.There was also a name clash on GCC for typedefs matching class names (e.g
using TimeQueue = TimeQueue).Otherwise, nothing functional.