add pydantic validators for rust types coming from bridge (#184)

* add pydantic validators for rust types coming from bridge

* cleanup logger

querent/config/collector/collector_config.py

@@ -27,7 +27,12 @@ class CollectorConfig(BaseModel):
     # Custom validator for ChannelCommandInterface
     @validator("channel", pre=True, allow_reuse=True)
     def validate_channel(cls, value):
-        # Perform any additional validation logic here
+        if not hasattr(value, "receive_in_python") or not hasattr(
+            value, "send_in_rust"
+        ):
+            raise ValueError(
+                "Invalid type for channel. Must have 'receive_in_python' and 'send_in_rust' functions."
+            )
         return value
 
 
@@ -36,6 +41,20 @@ class FSCollectorConfig(CollectorConfig):
     id: str
     root_path: str
     chunk_size: int = 1024
+    channel: Any
+
+    # Custom validator for ChannelCommandInterface
+    @validator("channel", pre=True, allow_reuse=True)
+    def validate_channel(cls, value):
+        if (
+            value is None
+            or not hasattr(value, "receive_in_python")
+            or not hasattr(value, "send_in_rust")
+        ):
+            raise ValueError(
+                "Invalid type for channel. Must have 'receive_in_python' and 'send_in_rust' functions."
+            )
+        return value
 
 
 class AzureCollectConfig(CollectorConfig):

querent/config/engine/engine_config.py

@@ -25,5 +25,10 @@ class EngineConfig(BaseModel):
     # Custom validator for ChannelCommandInterface
     @validator("channel", pre=True, allow_reuse=True)
     def validate_channel(cls, value):
-        # Perform any additional validation logic here
+        if not hasattr(value, "receive_in_python") or not hasattr(
+            value, "send_in_rust"
+        ):
+            raise ValueError(
+                "Invalid type for channel. Must have 'receive_in_python' and 'send_in_rust' functions."
+            )
         return value

querent/config/workflow/workflow_config.py

@@ -12,10 +12,18 @@ class WorkflowConfig(BaseModel):
 
     @validator("channel", pre=True, allow_reuse=True)
     def validate_channel(cls, value):
-        # Perform any additional validation logic here
+        if not hasattr(value, "receive_in_python") or not hasattr(
+            value, "send_in_rust"
+        ):
+            raise ValueError(
+                "Invalid type for channel. Must have 'receive_in_python' and 'send_in_rust' functions."
+            )
         return value
 
     @validator("event_handler", pre=True, allow_reuse=True)
     def validate_event_handler(cls, value):
-        # Perform any additional validation logic here
-        return value
+        # value must have handle_event function
+        if not hasattr(value, "handle_event"):
+            raise ValueError(
+                "Invalid type for event_handler. Must have 'handle_event' function."
+            )

querent/logging/logger.py

@@ -1,11 +1,11 @@
 import logging
+from logging.handlers import RotatingFileHandler
 from querent.config.logger.logger_config import (
     LOGGING_LEVEL,
     LOGGING_FORMAT,
     LOGGING_DATE_FORMAT,
     LOGGING_FILE,
 )
-from querent.logging.handlers import create_console_handler, create_file_handler
 
 
 def setup_logger(logger_name: str, log_file_id: str) -> logging.Logger:
@@ -17,15 +17,21 @@ def setup_logger(logger_name: str, log_file_id: str) -> logging.Logger:
         logger = logging.getLogger(logger_name)
         logger.setLevel(LOGGING_LEVEL)
 
-        console_handler = create_console_handler(LOGGING_FORMAT, LOGGING_DATE_FORMAT)
-        file_handler = create_file_handler(
-            log_file_name, LOGGING_FORMAT, LOGGING_DATE_FORMAT
+        console_handler = logging.StreamHandler()
+        console_handler.setFormatter(
+            logging.Formatter(LOGGING_FORMAT, LOGGING_DATE_FORMAT)
         )
-
         logger.addHandler(console_handler)
+
+        file_handler = RotatingFileHandler(
+            log_file_name, maxBytes=1024 * 1024, backupCount=5
+        )
+        file_handler.setFormatter(
+            logging.Formatter(LOGGING_FORMAT, LOGGING_DATE_FORMAT)
+        )
         logger.addHandler(file_handler)
 
         return logger
     except Exception as e:
-        print(f"Error while setting up logger: {e}")
+        logger.error(f"Error while setting up logger: {e}")
         return None