update: bootstrap and react bootstrap ver bump #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinwilliams91
requested review from
chris-watson,
Githubbubber,
mnyon-grandkru and
benjahmin-koenigsberg
|
package-lock is being pushed but I'm not sure if I should be doing that? Has there been a decision about this prior and if so should I add it to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a new clone directly from QG Organization Repo instead of my previous forked clone to fit QG dev git workflow procedures.
Per Meke's Comment about having a separate PR for my bootstrap and react-bootstrap version updates, I cherry picked that commit from my previous PR so that we can merge it and get the update without a bunch of other files changing.