-
-
Notifications
You must be signed in to change notification settings - Fork 66
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace revert with upstream patch regarding dm-crypt bug
- Loading branch information
Showing
3 changed files
with
44 additions
and
106 deletions.
There are no files selected for viewing
105 changes: 0 additions & 105 deletions
105
0001-Revert-dm-crypt-allocate-compound-pages-if-possible.patch
This file was deleted.
Oops, something went wrong.
43 changes: 43 additions & 0 deletions
43
0001-swiotlb-xen-provide-the-max_mapping_size-method.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
Date: Mon, 6 Nov 2023 18:12:30 +0100 (CET) | ||
From: Keith Busch <[email protected]> | ||
Subject: [PATCH v2] swiotlb-xen: provide the "max_mapping_size" method | ||
|
||
There's a bug that when using the XEN hypervisor with bios with large | ||
multi-page bio vectors on NVMe, the kernel deadlocks [1]. | ||
|
||
The deadlocks are caused by inability to map a large bio vector - | ||
dma_map_sgtable always returns an error, this gets propagated to the block | ||
layer as BLK_STS_RESOURCE and the block layer retries the request | ||
indefinitely. | ||
|
||
XEN uses the swiotlb framework to map discontiguous pages into contiguous | ||
runs that are submitted to the PCIe device. The swiotlb framework has a | ||
limitation on the length of a mapping - this needs to be announced with | ||
the max_mapping_size method to make sure that the hardware drivers do not | ||
create larger mappings. | ||
|
||
Without max_mapping_size, the NVMe block driver would create large | ||
mappings that overrun the maximum mapping size. | ||
|
||
Reported-by: Marek Marczykowski-Górecki <[email protected]> | ||
Link: https://lore.kernel.org/stable/ZTNH0qtmint%2FzLJZ@mail-itl/ [1] | ||
Tested-by: Marek Marczykowski-Górecki <[email protected]> | ||
Suggested-by: Christoph Hellwig <[email protected]> | ||
Cc: [email protected] | ||
Signed-off-by: Keith Busch <[email protected]> | ||
Signed-off-by: Mikulas Patocka <[email protected]> | ||
|
||
--- | ||
drivers/xen/swiotlb-xen.c | 1 + | ||
1 file changed, 1 insertion(+) | ||
|
||
Index: linux-stable/drivers/xen/swiotlb-xen.c | ||
=================================================================== | ||
--- linux-stable.orig/drivers/xen/swiotlb-xen.c 2023-11-03 17:57:18.000000000 +0100 | ||
+++ linux-stable/drivers/xen/swiotlb-xen.c 2023-11-06 15:30:59.000000000 +0100 | ||
@@ -405,4 +405,5 @@ const struct dma_map_ops xen_swiotlb_dma | ||
.get_sgtable = dma_common_get_sgtable, | ||
.alloc_pages = dma_common_alloc_pages, | ||
.free_pages = dma_common_free_pages, | ||
+ .max_mapping_size = swiotlb_max_mapping_size, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters