Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated external community doc links #1343

Closed
wants to merge 1 commit into from

Conversation

andrewdavidwong
Copy link
Member

@andrewdavidwong
Copy link
Member Author

I couldn't figure out how to programmatically replace every community GitHub link with a link to https://forum.qubes-os.org/c/guides/14, so I just removed them instead. However, I realized after submitting this PR that this will break all existing links to https://www.qubes-os.org/doc/* that were being redirected to those GitHub pages, so this is definitely not the best way to do things. Hopefully someone more skilled can do a better version of this, and this PR never has to be merged.

@marmarek
Copy link
Member

marmarek commented Nov 9, 2023

I couldn't figure out how to programmatically replace every community GitHub link with a link to https://forum.qubes-os.org/c/guides/14,

Is it okay to replace all with this very link (to the category, not individual guides)? If so, I can make a PR.

@andrewdavidwong
Copy link
Member Author

Is it okay to replace all with this very link (to the category, not individual guides)? If so, I can make a PR.

That's up to @unman. It was discussed in the linked thread, and the only consensus seems to be that more specific links would be better.

@unman
Copy link
Member

unman commented Nov 10, 2023 via email

@marmarek
Copy link
Member

A bit better approach here: #1346

@andrewdavidwong
Copy link
Member Author

Closing in favor of #1346.

@andrewdavidwong andrewdavidwong deleted the community-doc-migration branch December 11, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants