Rework domains widget #235
Conversation
fepitre
force-pushed
the
devel301124
branch
5 times, most recently
from
15c3e12 to
559df60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 93.18% 93.16% -0.02%
==========================================
Files 58 58
Lines 11046 11051 +5
==========================================
+ Hits 10293 10296 +3
- Misses 753 755 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Technically both of Pylint checks and Black formatting style are enforced here? If that is the case, it might be better to update Python specific Coding Style Guidelines as well. There is a brief line there with a link to PEP8.
Yes, but it's not yet enforced in guidelines. It's up to @marmarek but for now we have several other places to blacken first. |
|
|
||
| gi.require_version("Gtk", "3.0") # isort:skip | ||
| from gi.repository import Gio, Gtk, GObject, GLib, GdkPixbuf # isort:skip | ||
| from gi.repository import Gio, Gtk, GLib, GdkPixbuf # isort:skip |
There was a problem hiding this comment.
please don't move import gi away from this, it makes it more confusing...
There was a problem hiding this comment.
What do you mean? This dependency is not required anymore, how should I remove it?
There was a problem hiding this comment.
oh, sorry, wrong line - my problem is that you moved import gi above this line, and I think it shoulld be in its old location, just above gi.require_version
Yes I'm aware of this but I was waiting on current refactor before fighting with margins. |
|
@fepitre can you move the reformatting to a separate PR? |
fepitre
force-pushed
the
devel301124
branch
4 times, most recently
from
ffd5d68 to
c088f6f
Compare
|
As discussed in private chat, I've added |
|
Also, there is still big left margin, I'm trying to figure out the reason. |
|
I also fixed vanished separator on the menu. |
Many thanks to @marmarta!
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025011103-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update
Failed tests16 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/119126#dependencies 3 fixed
Unstable tests
|
|
Sooo, I generally really like it, but maybe if you moved vm icons 1 pixel closer to text, openqa won't complain? I think that's the difference there (otherwise someone has to click through openqa :D) |
|
OTOH, maybe trying to exactly fit the pixel requirements of OpenQA is a bad idea and clicking through those is the better one. |
|
fixed OpenQa screenshots. |
It fixes QubesOS/qubes-issues#7754.