Use allow-all-names instead of allow-unsafe-characters #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out by Andrew David Wong the latter name is unnecessarily alarming. No backwards compatibility is provided because users should not need to remember to blocklist two different strings in their qrexec policies. Denying "+allow-all-names" should be sufficient. Reported-by: Andrew David Wong <[email protected]> Fixes: QubesOS/qubes-issues#8332 (for real this time)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
- Coverage 70.57% 70.14% -0.43%
==========================================
Files 3 3
Lines 469 469
==========================================
- Hits 331 329 -2
- Misses 138 140 +2 ☔ View full report in Codecov by Sentry. |
marmarek
approved these changes
Jun 24, 2024
marmarek
added a commit
to marmarek/qubes-core-admin
that referenced
this pull request
Jun 24, 2024
It was renamed from allow-unsafe-characters to allow-all-names See QubesOS/qubes-core-agent-linux#508 QubesOS/qubes-issues#8332
marmarek
added a commit
to QubesOS/qubes-core-admin
that referenced
this pull request
Jun 25, 2024
It was renamed from allow-unsafe-characters to allow-all-names See QubesOS/qubes-core-agent-linux#508 QubesOS/qubes-issues#8332 (cherry picked from commit 872119f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by Andrew David Wong the latter name is unnecessarily alarming. No backwards compatibility is provided because users should not need to remember to blocklist two different strings in their qrexec policies. Denying "+allow-all-names" should be sufficient.
Reported-by: Andrew David Wong [email protected]
Fixes: QubesOS/qubes-issues#8332 (for real this time)