Extend clipboard tests #623
Conversation
Make it easier to add similar tests with different content. No functional change yet.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
=======================================
Coverage 69.32% 69.32%
=======================================
Files 58 58
Lines 11993 11993
=======================================
Hits 8314 8314
Misses 3679 3679
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
FYI @alimirjamali I extended clipboard tests to check few more sizes. I consider adding also one above 256k, but not sure if that's necessary. This should cover testing new version. Interaction of new gui-daemon with old gui-agent needs to be tested manually. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024102523-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests16 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 201 fixed
Unstable tests
|
That is very nice. The test for above 256k will be necessary. Rejecting INCR is easy and could be easily added (after I could finish the existing PR). |
marmarek
force-pushed
the
tests-clipboard-limit
branch
from
6b8a189
to
2c4b3f9
Compare
|
There should be a unittest where inter-vm shared clipboard content is over 65000 (from a Protocol 1.8 aware VM) and user tries to paste it to a VM with protocol 1.7 with 65000 character limit. xside should handle this gracefully. |
There seems to be no difference in the paste path between versions, so I expect the current test (200k) to cover this case already. |
OK. So no forced limit from the xside to vmside. Makes very sense. Better to keep it this way (now that I reconsider it). |
marmarek
force-pushed
the
tests-clipboard-limit
branch
3 times, most recently
from
83f6ace
to
6ee52ad
Compare
Check if copying 64k also works. And then try copying 200kb, both with default settings (should be refused) and with limit raised. This test assume already modified behavior on over the limit copy (truncate to 0 instead of truncating to the limit). Finally, test copying 300k, which should be rejected regardless of the limit. Change also `zenity --entry` to `zenify --text-info --editable` as the former supports only up to 65535 characters. QubesOS/qubes-issues#9296
Zenity needs a bit of time to actually copy longer text. Wait a bit before hitting ctrl+shift+c.
marmarek
force-pushed
the
tests-clipboard-limit
branch
from
6ee52ad
to
b4df77d
Compare
QubesOS/qubes-issues#9296