Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore PCI devices on non-0000 domain instead of crashing #560

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

marmarek
Copy link
Member

This is a quick band-aid to unbreak Qubes on systems having such device.
Later change should implement handling them properly instead of ignoring.

Fixes QubesOS/qubes-issues#6932

This is a quick band-aid to unbreak Qubes on systems having such device.
Later change should implement handling them properly instead of
ignoring.

Fixes QubesOS/qubes-issues#6932
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #560 (b249cc2) into main (c965d85) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   67.14%   67.25%   +0.10%     
==========================================
  Files          55       55              
  Lines       11131    11140       +9     
==========================================
+ Hits         7474     7492      +18     
+ Misses       3657     3648       -9     
Flag Coverage Δ
unittests 67.25% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
qubes/ext/pci.py 39.15% <100.00%> (+8.04%) ⬆️

@marmarek marmarek merged commit 5f83cec into QubesOS:main Oct 11, 2023
@docelic
Copy link

docelic commented Oct 16, 2023

Related/duplicate bug report: QubesOS/qubes-issues#8143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing PCI devices breaks when there is some with non-0000 PCI domain
2 participants