Simple server optimizations #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causes an unnecessary exception
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 53.93% 54.05% +0.11%
==========================================
Files 55 55
Lines 8452 8495 +43
==========================================
+ Hits 4559 4592 +33
- Misses 3893 3903 +10
Continue to review full report at Codecov.
|
|
Oh, you've already did this. See comments on #165. |
qubesuser
force-pushed
the
optimizations
branch
4 times, most recently
from
7559bb9
to
311b8f2
Compare
it's unused and has a netid property with name different than key that would cause issues in the next commit
currently it takes 100ms+ to determine the default pool every time, including subprocess spawning (!), which is unacceptable since finding out the default value of properties should be instantaneous instead of checking every thin pool to see if the root device is in it, find and cache the name of the root device thin pool and see if there is a configured pool with that name
qubesuser
force-pushed
the
optimizations
branch
from
311b8f2
to
edae7a1
Compare
|
Finally got the tests to pass... |
marmarek
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of optimizations consisting of the changes in the "speed up qvm-ls" branch that don't make architectural or API changes.
The default pool change is particularly impactful since it stops spending 100ms+ with subprocess spawning every time we want to find out what the default pool is.