Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: QubesOS/qubes-core-agent-linux#550
I did that, but it seems that it is difficult to limit the amount of bytes that can be read as
proc.communicate(timeout=1)
is a blocking operation as well asproc.stdout.read(2)
To ensure a domU doesn't fill up Dom0 memory that is being assigned to
untrusted_mem
, something like this would have to be done: https://stackoverflow.com/a/34114767, unless someone knows a better solution.