Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "multimedia" devices more detailed #322

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

marmarek
Copy link
Member

Distinguish between audio, video and display adapters. This is
especially relevant when setting up sys-audio or sys-gui-gpu, otherwise
it's hard to find which "multimedia" device is the right one.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.22%. Comparing base (0f3fb1b) to head (34d5e8d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
qubesadmin/device_protocol.py 76.19% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   75.26%   75.22%   -0.04%     
==========================================
  Files          52       52              
  Lines        8950     8958       +8     
==========================================
+ Hits         6736     6739       +3     
- Misses       2214     2219       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qubesos-bot
Copy link

qubesos-bot commented Nov 27, 2024

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024121602-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update

  • system_tests_basic_vm_qrexec_gui

    • TC_30_Gui_daemon: test_002_clipboard_200k (failure)
      AssertionError: '' != 'test123ab\ntest123ab\ntest123ab\ntest123a[21...
  • system_tests_extra

    • TC_00_QVCTest_debian-12-xfce: test_010_screenshare (failure)
      AssertionError: 7.933165427175505 not less than 2.0
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

Failed tests

4 failures
  • system_tests_basic_vm_qrexec_gui

    • TC_30_Gui_daemon: test_002_clipboard_200k (failure)
      AssertionError: '' != 'test123ab\ntest123ab\ntest123ab\ntest123a[21...
  • system_tests_extra

    • TC_00_QVCTest_debian-12-xfce: test_010_screenshare (failure)
      AssertionError: 7.933165427175505 not less than 2.0
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/119126#dependencies

3 fixed
  • system_tests_extra

    • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
  • system_tests_basic_vm_qrexec_gui_zfs

    • switch_pool: Failed (test died)
      # Test died: command 'dnf install -y ./zfs-release.rpm' failed at /...
  • system_tests_audio@hw1

Unstable tests

  • system_tests_basic_vm_qrexec_gui_zfs

    TC_00_Basic/test_120_start_standalone_with_cdrom_dom0 (1/5 times with errors)
    • job 109480 AssertionError: 1 != 0 : b'Timeout waiting for dom0:loop6 device to...
  • system_tests_audio

    TC_20_AudioVM_PipeWire_fedora-40-xfce/test_260_audio_mic_enabled_switch_audiovm (1/5 times with errors)
    • job 117586 AssertionError: too short audio, expected 10s, got 0.00013605442176...
  • system_tests_audio@hw1

    TC_20_AudioVM_PipeWire_fedora-40-xfce/test_260_audio_mic_enabled_switch_audiovm (1/5 times with errors)
    • job 117586 AssertionError: too short audio, expected 10s, got 0.00013605442176...

Distinguish between audio, video and display adapters. This is
especially relevant when setting up sys-audio or sys-gui-gpu, otherwise
it's hard to find which "multimedia" device is the right one.
Update mostly type hints.
@marmarek marmarek force-pushed the detailed-multimedia branch from 4756bd9 to 34d5e8d Compare December 16, 2024 09:57
@marmarek marmarek merged commit 34d5e8d into QubesOS:main Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants