Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for non-square / uniform MPOHamiltonians in make_time_mpo(..., ::TaylorCluster) #253

Merged
merged 13 commits into from
Mar 2, 2025

Conversation

VictorVanthilt
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 89.69072% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/algorithms/timestep/wii.jl 62.96% 20 Missing ⚠️
Files with missing lines Coverage Δ
src/MPSKit.jl 100.00% <ø> (ø)
src/algorithms/timestep/taylorcluster.jl 100.00% <100.00%> (ø)
src/algorithms/timestep/time_evolve.jl 100.00% <ø> (ø)
src/operators/abstractmpo.jl 57.14% <100.00%> (+1.21%) ⬆️
src/operators/mpohamiltonian.jl 88.95% <100.00%> (ø)
src/algorithms/timestep/wii.jl 62.96% <62.96%> (ø)

... and 4 files with indirect coverage changes

@lkdvos lkdvos force-pushed the vv-GeneralTaylorCluster branch from fbe1aff to 2bad503 Compare February 21, 2025 01:51
@lkdvos
Copy link
Member

lkdvos commented Feb 21, 2025

I made an attempt at fixing this, I have something that seems to be running, and at least locally produces the correct scaling behavior. Comparing the 2nd order infinite result though, it seems like we obtain a 6x6 matrix for a nearest-neighbour model, which does not match the 3x3 that the paper shows (appendix A).
Honestly, I would love to just write down and compare to these exact expressions as a testcase, I also don't think the tests you added are working...

@lkdvos lkdvos force-pushed the vv-GeneralTaylorCluster branch from 429e6ce to f3b97b5 Compare February 26, 2025 15:46
@VictorVanthilt VictorVanthilt enabled auto-merge (squash) February 26, 2025 19:49
@lkdvos lkdvos force-pushed the vv-GeneralTaylorCluster branch from 395a3ce to bacd649 Compare February 28, 2025 22:44
@lkdvos lkdvos force-pushed the vv-GeneralTaylorCluster branch from bacd649 to 261ad0e Compare February 28, 2025 23:03
@VictorVanthilt VictorVanthilt merged commit d91262b into master Mar 2, 2025
28 checks passed
@VictorVanthilt VictorVanthilt deleted the vv-GeneralTaylorCluster branch March 2, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants