Minor refactoring of KS test. #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 93.75% 89.72% -4.04%
==========================================
Files 15 15
Lines 1586 1577 -9
==========================================
- Hits 1487 1415 -72
- Misses 99 162 +63
Continue to review full report at Codecov.
|
kklein
changed the title
YYYasin19
reviewed
Jul 28, 2022
| table1_selection = f"({table1_selection})" | ||
| table2_selection = f"({table2_selection})" | ||
| # For mssql: "tempdb.dbo".table_name -> tempdb.dbo.table_name | ||
| table1_str = str(ref1.data_source.get_clause(engine)).replace('"', "") |
There was a problem hiding this comment.
Nice, didn't know you'd get the clean table name incl. parentheses (...) this way. Very clean!
YYYasin19
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KolmogorovSmirnov2Sample:Conditions are ignored #42