Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust admonition title background specificity to allow proof override #248

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

DrDrij
Copy link
Member

@DrDrij DrDrij commented Jul 29, 2024

By changing the way we address the admonition title, we allow the sphinx proof stylesheet to affect background colour when using QuantEcon book theme.

Addressing: QuantEcon/lecture-python-intro#493

By changing the way we address the admonition title, we allow the sphinx proof stylesheet to affect background colour when using QuantEcon book theme.
@mmcky
Copy link
Contributor

mmcky commented Aug 20, 2024

thanks @DrDrij -- I suspect the test cases for CI are out of date with this change. I will try and see if we have some documentation to update it

@DrDrij
Copy link
Member Author

DrDrij commented Aug 20, 2024

Matt, please let me know how I can be most useful here, and less work for you (if possible). Feel guilty with the more complex solution without managing to properly explain it to you. Thanks!

@mmcky mmcky merged commit 51969bf into master Sep 8, 2024
5 of 11 checks passed
@mmcky mmcky deleted the admonition-style-update branch September 8, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants