Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Upgrade software stack #292

Merged
merged 5 commits into from
Oct 11, 2023
Merged

MAINT: Upgrade software stack #292

merged 5 commits into from
Oct 11, 2023

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Oct 4, 2023

This PR upgrades to:

  • anaconda==2023.09
  • python=3.11
  • quantecon-book-theme==0.6.0

@mmcky
Copy link
Contributor Author

mmcky commented Oct 4, 2023

@HumphreyYang would you have time to look into this link checker result?

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

@github-actions github-actions bot temporarily deployed to pull request October 4, 2023 00:45 Inactive
@mmcky mmcky changed the title MAINT: Upgrade to python=3.11 and anaconda==2023.09 MAINT: Upgrade software stack Oct 4, 2023
@HumphreyYang HumphreyYang reopened this Oct 4, 2023
@mmcky
Copy link
Contributor Author

mmcky commented Oct 4, 2023

  • re-run without cache

@HumphreyYang
Copy link
Collaborator

HumphreyYang commented Oct 4, 2023

Many thanks @mmcky,

The link checker is all green now.

@mmcky
Copy link
Contributor Author

mmcky commented Oct 4, 2023

thanks @HumphreyYang love your work.

@mmcky
Copy link
Contributor Author

mmcky commented Oct 4, 2023

  • re-enable the build cache

@mmcky mmcky mentioned this pull request Oct 4, 2023
@github-actions github-actions bot temporarily deployed to pull request October 4, 2023 01:17 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Oct 4, 2023

@HumphreyYang @HengchengZhang if you had 10minutes would you mind to look through the latest deployment and let me know if you spot any issues or regressions.

@HengchengZhang
Copy link
Member

Hi Matt, the new search bar and the dark mode looks all good to me.

One minor thing I can mention is that the color of code block in dark mode, they are now the same color as in bright mode with a dark background. I think it would be better to have a seperate color map for that if possible?

It is still great if we use the current theme.

@mmcky
Copy link
Contributor Author

mmcky commented Oct 4, 2023

Hi Matt, the new search bar and the dark mode looks all good to me.

One minor thing I can mention is that the color of code block in dark mode, they are now the same color as in bright mode with a dark background. I think it would be better to have a seperate color map for that if possible?

It is still great if we use the current theme.

Thanks @HengchengZhang -- I agree we need to make improvements to the theme. Are you indicating that quantecon-book-theme==0.6.0 is worse than our current live site which uses quantecon-book-theme==0.5.3?

@HengchengZhang
Copy link
Member

Hi Matt, the new search bar and the dark mode looks all good to me.
One minor thing I can mention is that the color of code block in dark mode, they are now the same color as in bright mode with a dark background. I think it would be better to have a seperate color map for that if possible?
It is still great if we use the current theme.

Thanks @HengchengZhang -- I agree we need to make improvements to the theme. Are you indicating that quantecon-book-theme==0.6.0 is worse than our current live site which uses quantecon-book-theme==0.5.3?

Hi @mmcky I think the new quantecon-book-theme==0.6.0 is better than current site but the code part can be improved. But still the new theme is pretty nice.

@mmcky
Copy link
Contributor Author

mmcky commented Oct 11, 2023

thanks @HumphreyYang and @HengchengZhang for your review and comments.

Upgrading to the latest versions now.

@mmcky mmcky merged commit 2c15456 into main Oct 11, 2023
4 checks passed
@mmcky mmcky deleted the maint-04oct branch October 11, 2023 03:23
@github-actions github-actions bot temporarily deployed to pull request October 11, 2023 03:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants