Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unpleasent] spell check #535

Merged
merged 1 commit into from
Jul 25, 2024
Merged

[unpleasent] spell check #535

merged 1 commit into from
Jul 25, 2024

Conversation

longye-tian
Copy link
Collaborator

Dear John @jstac and Matt @mmcky ,

This pull request reviews the spellings of the lecture unpleasant.md and check whether we need to add example admonition according to #532 and #520 .

In this pull request, we

  • change 'portolio' to 'portolio'
  • change 'it's supply' to 'its supply'
  • change '... that let's us' to '... that lets us'
  • we find no examples to include in the example admonition

Best ❤️
Longye

@netlify Netlify
Copy link

netlify bot commented Jul 25, 2024 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 4231e89
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66a1973da9ba5e0008002ef4
😎 Deploy Preview https://deploy-preview-535--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Jul 25, 2024
Open
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

🚀 Deployed on https://66a1991d8dc8216d70c5e362--taupe-gaufre-c4e660.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 25, 2024 00:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 25, 2024 00:15 Inactive
@longye-tian longye-tian requested a review from mmcky July 25, 2024 00:38
@longye-tian longye-tian self-assigned this Jul 25, 2024
mmcky
mmcky approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @longye-tian

@mmcky mmcky merged commit 457fc52 into main Jul 25, 2024
8 checks passed
@mmcky mmcky deleted the unpleasant_example_spelling branch July 25, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky approved these changes

Assignees

@longye-tian longye-tian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longye-tian @mmcky