Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lp_intro]Update lp #531

Merged
merged 3 commits into from
Jul 26, 2024
Merged

[lp_intro]Update lp #531

merged 3 commits into from
Jul 26, 2024

Conversation

longye-tian
Copy link
Collaborator

@longye-tian longye-tian commented Jul 23, 2024 •
edited
Loading

Dear John @jstac and Matt @mmcky ,

This pull request update lecture lp_intro.md according to #514

In particular, this pull request

  • add explanation on 'iso-revenue lines'
  • add commas in the numbers to be consistent
  • I also find there is no need to add example environment in this lecture as all the examples are the main text.
  • This lecture also pass the spelling/grammar check

Best ❤️
Longye

@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 980e784
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/669f907435c12f00088d3eba
😎 Deploy Preview https://deploy-preview-531--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

🚀 Deployed on https://669f926615cc1c04c5383a58--taupe-gaufre-c4e660.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 09:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 09:47 Inactive
@longye-tian longye-tian self-assigned this Jul 23, 2024
This was referenced Jul 23, 2024
Open
Open
mmcky
mmcky approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @longye-tian.

mmcky
mmcky reviewed Jul 23, 2024
View reviewed changes
lectures/lp_intro.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 11:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 11:22 Inactive
@mmcky mmcky merged commit c814e4e into main Jul 26, 2024
7 checks passed
@mmcky mmcky deleted the update_lp branch July 26, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky approved these changes

Assignees

@longye-tian longye-tian

Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longye-tian @mmcky