[inflation_history] ENH: Implement review suggestions and comments

[mmcky]

This PR addresses #390

STATUS: IN-WORK

• Check why the index starts from 1915 in df_fig5_bef1914. Comment: updated variable name to align with text that ends at 1914. The index ends at 1914 in the dataframe (and used to end at 1915 due to filter value in pandas).
• Set global dpi default. Comment: This was an indirect way to make the specific figure in question larger (due to the content). This is a special case figure and so I have updated it to specify a figsize to ensure it is large enough to show the content. This is more in line with out policy https://manual.quantecon.org/styleguide/figures.html
• variable name m_seq. Comment: removed as not used.
• Remove dots and connect them. @HumphreyYang do you recall what this comment means. Should the figures be updated with connected line graphs?
• Add a discussion on money supply and price level. Note: won't address in this PR.
• Is "1/cents per polish mark" the same as "polish marks per cent"? In which case let's change to "Polish marks per US cent". (see @SylviaZhaooo or @longye-tian below)

[netlify]

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name	Link
🔨 Latest commit	7dd069b
🔍 Latest deploy log	https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/669f3aad10ab3200086f84d9
😎 Deploy Preview	https://deploy-preview-494--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[HumphreyYang]

• Remove dots and connect them. @HumphreyYang do you recall what this comment means. Should the figures be updated with connected line graphs?

Many thanks @mmcky. I think this is referring to the moving average plot, and we were discussing whether should we remove the data points and leave the moving average line or just connect the monthly inflation data points.

Some think the current version looks good but some suggest removing the points in the graph will look cleaner. I think this is why it is not implemented. Please let us know your thoughts.

[github-actions]

🚀 Deployed on https://669f3c9dcc801eb9fbfcd689--taupe-gaufre-c4e660.netlify.app

[mmcky]

• Remove dots and connect them. @HumphreyYang do you recall what this comment means. Should the figures be updated with connected line graphs?

Many thanks @mmcky. I think this is referring to the moving average plot, and we were discussing whether should we remove the data points and leave the moving average line or just connect the monthly inflation data points.

Some think the current version looks good but some suggest removing the points in the graph will look cleaner. I think this is why it is not implemented. Please let us know your thoughts.

thanks @HumphreyYang I think using the moving average line only is best here. I have adjusted in 58d65ee

[mmcky]

@SylviaZhaooo or @longye-tian would you mind helping to finish off this PR.

Is "1/cents per polish mark" the same as "polish marks per cent"? In which case let's change to "Polish marks per US cent".

I can confirm we need to change these cases as suggested above. This applies to Polish marks (+ other currencies as well). It will require a bit of rework of the code (i.e. pandas columns) in addition to the graph titles that are generated.

[longye-tian]

@SylviaZhaooo or @longye-tian would you mind helping to finish off this PR.

Is "1/cents per polish mark" the same as "polish marks per cent"? In which case let's change to "Polish marks per US cent".

I can confirm we need to change these cases as suggested above. This applies to Polish marks (+ other currencies as well). It will require a bit of rework of the code (i.e. pandas columns) in addition to the graph titles that are generated.

Hi Matt,

Sure thing. I will look into it and let you know if I'm stuck.

Best,
Longye

[longye-tian]

@SylviaZhaooo or @longye-tian would you mind helping to finish off this PR.

Is "1/cents per polish mark" the same as "polish marks per cent"? In which case let's change to "Polish marks per US cent".

I can confirm we need to change these cases as suggested above. This applies to Polish marks (+ other currencies as well). It will require a bit of rework of the code (i.e. pandas columns) in addition to the graph titles that are generated.

Hi Matt @mmcky ,

I just committed the changes for all the currencies on the label.

What do you think? Would you like to change something?

Best,
Longye

[mmcky]

thanks @longye-tian -- this looks ready to merge.