Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update_money_inflation_nonlinear] Editorial Suggestion #448

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

longye-tian
Copy link
Collaborator

Dear John @jstac,

This updates the lecture money_inflation_nonlinear.md according to #446.

In particular, this includes

Code

  • Remove the grid.
  • Change the legend for the Laffer curve plot to "Laffer curve". Also, use default colors in matplotlib.

Content

  • Bold face is reserved for definitions and italics are used for emphases.
  • Only the first word in the title should be capitalized.
  • Migrate some of "This lecture studies" to "We study ...".
  • Maintain consistent use of bar and overline.
  • (28.3) repeats (28.2). Consider removing (28.3) and adjusting the links to (28.2) if (28.3) is removed.
  • Define all the notations like $\pi$ and $m$.
  • "limiting values exists" -> exist
  • "...that studies a linear version of the model in this lecture`" -> "that studies a linear version of the model in this lecture."
  • In Equation (28.6) we have $x: x \ge 0$. Remove "x:", and put a curly bracket covering the equation after max to indicate the scope of max.

Best ❤️
Longye

This updates the lecture money_inflation_nonlinear.md according to #446.

In particular, this includes
## Code
- Remove the grid.
- Change the legend for the [Laffer curve plot](https://intro.quantecon.org/money_inflation_nonlinear.html#laffer-curve-nonlinear) to "Laffer curve". Also, use default colors in `matplotlib`.

## Content
- Bold face is reserved for definitions and italics are used for emphases.
- Only the first word in the title should be capitalized.
- Migrate some of "This lecture studies" to  "We study ...".
- Maintain consistent use of bar and overline.
- (28.3) repeats (28.2). Consider removing (28.3) and adjusting the links to (28.2) if (28.3) is removed.
- Define all the notations like $\pi$ and $m$.
- "limiting values exists" -> exist
-  "...that studies a linear version of the model in this lecture`"  -> "that studies a linear version of the model in this lecture."
- In Equation (28.6) we have $x: x \ge 0$. Remove "x:", and put a curly bracket covering the equation after max to indicate the scope of max.
@longye-tian longye-tian requested a review from mmcky May 23, 2024 08:23
Copy link

netlify bot commented May 23, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 193ad00
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66511a303ba4860008fb1a3c
😎 Deploy Preview https://deploy-preview-448--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@longye-tian longye-tian requested a review from jstac May 23, 2024 08:24
Copy link

github-actions bot commented May 23, 2024

@github-actions github-actions bot temporarily deployed to pull request May 23, 2024 08:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 23, 2024 08:32 Inactive
@longye-tian longye-tian changed the title update_money_inflation_nonlinear [update_money_inflation_nonlinear] Editorial Suggestion May 24, 2024
@jstac
Copy link
Contributor

jstac commented May 24, 2024

Thanks @longye-tian !

Would you mind to also search for {doc} and delete "this lecture" or "the lecture" in each case?

Delete 'this lecture' before {doc}.
@longye-tian
Copy link
Collaborator Author

Thanks @longye-tian !

Would you mind to also search for {doc} and delete "this lecture" or "the lecture" in each case?

Sure thing! Just updated this pull request about this.

@github-actions github-actions bot temporarily deployed to pull request May 24, 2024 22:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 24, 2024 23:00 Inactive
@jstac
Copy link
Contributor

jstac commented May 25, 2024

Perfect. Many thanks @longye-tian .

@mmcky Could you please skim this and then merge when ready?

@mmcky
Copy link
Contributor

mmcky commented Jun 17, 2024

thanks @longye-tian and @jstac this is looking good to me. I will merge.

@mmcky mmcky merged commit 441606f into main Jun 17, 2024
7 checks passed
@mmcky mmcky deleted the update_money_inflation_nonlinear branch June 17, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants