Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

Remove duplicate validation of wrong input parameters #9

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Feb 27, 2024

Description

We have the same validation in GetHistory() method, must remove.

Related Issue

N/A

Motivation and Context

make code clean and neat.

Requires Documentation Change

N/A

How Has This Been Tested?

Run CI/CD.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit 1d47274 into QuantConnect:master Feb 27, 2024
1 check failed
@Romazes Romazes deleted the remove-extra-spamming-flags-in-data-downloader branch March 14, 2024 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants