feat: Qdrant RAG Storage #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anush008 <[email protected]>
Anush008
commented
Dec 24, 2024
Signed-off-by: Anush008 <[email protected]>
Signed-off-by: Anush008 <[email protected]>
pmeier
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Hi @Anush008 👋 and thanks a ton for the contribution. The patch looks really good already! I have a few small comments, but otherwise this is almost good to go!
Don't worry about the failing doc CI. I'm currently catching up after some hiatus and haven't gotten around to open an issue for it.
pmeier
reviewed
Dec 30, 2024
|
Hi @pmeier. Thanks for reviewing. |
Co-authored-by: Philip Meier <[email protected]>
Co-authored-by: Philip Meier <[email protected]>
pmeier
reviewed
Jan 3, 2025
Co-authored-by: Philip Meier <[email protected]>
Signed-off-by: Anush008 <[email protected]>
|
Thanks Anush, LGTM! Any remaining nits that I might have, I'll fix myself. However, we need to wait until #524 (comment) is resolved. @smokestacklightnin is actively working on that. I'll merge afterwards if CI stays green. |
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Qdrant - https://qdrant.tech/ to be used as RAG storage.