Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate usernames & their identifiers #15

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Validate usernames & their identifiers #15

merged 6 commits into from
Nov 28, 2023

Conversation

jaimergp
Copy link
Collaborator

Closes #14

@jaimergp jaimergp requested a review from aktech November 28, 2023 13:57
aktech
aktech reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@aktech aktech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, but looks good otherwise.

aktech
aktech approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaimergp jaimergp merged commit 90eefd0 into main Nov 28, 2023
1 check passed
@jaimergp jaimergp deleted the validate-ids branch November 28, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aktech aktech aktech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github usernames vs identifier
2 participants
@jaimergp @aktech